-
Notifications
You must be signed in to change notification settings - Fork 125
fix(structured_logs): Remove prefix #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
prefix-output.sh (2)
5-9
: Make the feature-flag check more robust
The comparison is case-sensitive and treats any non-"true"
value (including"TRUE"
or"1"
) as disabled. Consider normalising or using a shell pattern:case "${SOURCEBOT_STRUCTURED_LOGGING_ENABLED,,}" in true|1|yes) exec "$@";; esacThis allows intuitive truthy values while keeping current behaviour the default.
1-1
: Filename deviates from camelCase guideline
prefix-output.sh
is kebab-case; the coding guidelines mandate camelCase unless neighbouring files use a different scheme. Rename toprefixOutput.sh
for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
prefix-output.sh
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
prefix-output.sh
🪛 Shellcheck (0.10.0)
prefix-output.sh
[warning] 11-11: In POSIX sh, process substitution is undefined.
(SC3001)
[warning] 12-12: In POSIX sh, process substitution is undefined.
(SC3001)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
Fixes #437
@GabDug
Summary by CodeRabbit