This repository was archived by the owner on Feb 21, 2025. It is now read-only.
Drop checking of external links on CI #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns out to be flaky and problematic.
RealOrangeOne
suggested changes
Apr 15, 2018
| "spellcheck": "mdspell --en-gb --report --ignore-acronyms --ignore-numbers --no-suggestions 'content/**/*.md'", | ||
| "broken-link-local": "blcl --recursive --ordered --exclude-external ./public/", | ||
| "broken-link-all": "blcl --recursive --ordered ./public/", | ||
| "test": "npm run spellcheck && npm run broken-link-local", |
There was a problem hiding this comment.
Could we keep these scripts, and just copy the diff from sourcebots/volunteer-docs#36. It means that (if required), we can still run the full link checker locally
There was a problem hiding this comment.
Why? They don't work (specifically, once #31 merges, broken-link-all will always get stuck on uos.svg) and I'd rather not leave broken things in place.
If we want to fix them, they're in the history and easy to get back.
RealOrangeOne
approved these changes
Apr 15, 2018
| "spellcheck": "mdspell --en-gb --report --ignore-acronyms --ignore-numbers --no-suggestions 'content/**/*.md'", | ||
| "broken-link-local": "blcl --recursive --ordered --exclude-external ./public/", | ||
| "broken-link-all": "blcl --recursive --ordered ./public/", | ||
| "test": "npm run spellcheck && npm run broken-link-local", |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns out to be flaky and problematic.