Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(chore): fix sonar code smells #150

Merged
merged 1 commit into from
Jan 8, 2024
Merged

refactor(chore): fix sonar code smells #150

merged 1 commit into from
Jan 8, 2024

Conversation

sf-sahil-jassal
Copy link
Contributor

@sf-sahil-jassal sf-sahil-jassal commented Jan 5, 2024

fix sonar code smells related to magic numbers and cognitive complexity

GH-148

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #148

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

fix sonar code smells related to magic numbers and cognitive complexity

GH-148
@yeshamavani yeshamavani merged commit 85e18e4 into master Jan 8, 2024
4 checks passed
@yeshamavani yeshamavani deleted the gh-148 branch January 8, 2024 09:21
@yeshamavani
Copy link
Contributor

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all sonar issues.
2 participants