[Bug] Sourcegit overwrites my GPG signature config

[thomaslevesque]

When I just open the Preferences dialog and close it without making any change, Sourcegit adds this at the end of my global git config:

[commit]
	gpgsign = false
[tag]
	gpgsign = false
[gpg "openpgp"]
	program = c:/Program Files (x86)/GnuPG/bin/gpg.exe

This overwrites a previous setting that sets commit.gpgsign to true. I only realized because the Github project I push to is configured to only accept signed commits.

Note that my Git config is a bit unusual. I use the same computer for work and personal projects, so I have a setup like this:

[includeIf "gitdir:C:/Personal/code/"]
	path = C:/Personal/code/.gitconfig
[includeIf "gitdir:C:/Work/code/"]
	path = C:/Work/code/.gitconfig

The GPG signature settings (user.signingkey and commit.gpgsign) are set in the included files, not directly in the global .gitconfig file.

[thomaslevesque]

It doesn't overwrite settings that were directly set in the global .gitconfig, only those specified in the included config files.

[love-linger]

If some of the configuration data is only used by specified repository, why not use local configure file of that repository directly?

[thomaslevesque]

If some of the configuration data is only used by specified repository, why not use local configure file of that repository directly?

Because it affects many repositories, and I don't want to repeat the config in each one.
Anyway, it's a valid Git configuration, so it should be handled correctly by Sourcegit.
I don't think Sourcegit needs to specifically handle the includeIf part. Just calling git config commit.gpgsign in a repo gives the correct value, taking the includes into account.

[thomaslevesque]

Because it affects many repositories, and I don't want to repeat the config in each one.

To clarify, the paths specified in includeIf are not paths to a specific repository, but to a directory that contains many repositories.

[love-linger]

Another way to resolve this issue is that you can move this settings before includeIf section. For example:

[commit]
	gpgsign = false
[tag]
	gpgsign = false
[gpg "openpgp"]
	program = c:/Program Files (x86)/GnuPG/bin/gpg.exe

...

[includeIf "gitdir:xxx"]
...

[thomaslevesque]

I guess I could, but that's a workaround, not a fix 😉
How is Sourcegit reading the configuration? Doesn't it just use git config? Or the libgit equivalent?

[love-linger]

I guess I could, but that's a workaround, not a fix 😉 How is Sourcegit reading the configuration? Doesn't it just use git config? Or the libgit equivalent?

Yes, for Preference window, it use git config --global command to get or set global git configuration.

[thomaslevesque]

Ah, I see. With --global it won't show the location specific settings.
Not sure what the right solution would be. It would make sense to have my includeIf at the end of the global git config, so that it overrides everything that comes before, but every time I set a global setting it will be added at the end, potentially overriding my location-specific config...
I guess it's an issue with Git rather than Sourcegit, then. Feel free to close, unless you have a great idea to fix it!

[love-linger]

This project do not use any other libraries to read or write repositories. Instead, it only use official git commands. That's why git is required by this app.

[thomaslevesque]

Related: https://stackoverflow.com/questions/78634897/git-config-option-not-being-overriden-in-an-includeif-config-file

[love-linger]

In fact, I really don't have a better idea. That's why the label for this issue has changed from bug to question.