[fix] On branch checkout I cannot change the local changes behavior

[albertodlc]

I changed the checkout behavior from local changes: Do nothing to local changes: discard and now I don't see how can change it back. When I press checkout, the popup does not allow to change the radiobutton. It automatically discard them.

I think the way this is handled should be changed, the popup should always display and allow the user to change and press the confirm button. In my case I changed the behavior for a specific checkout, and I lost some changes later because I think the checkout would ask for confirmation.

[albertodlc]

By checkout behavior and local changes radiobuttons I mean this popup:

Once it is set to discard, I cannot change it back on the next checkouts

[love-linger]

I can NOT reproduce this issue.

test.mp4

If there are some un-committed local changes, the Checkout popup should always show. Try to press and release Ctrl (Command on macOS) again - It seems it triggred the Hold Ctrl to start directly

[love-linger]

I've pushed a commit that fix some issue about change the way to deal with local changes. You can try the latest build from Github Action.

[love-linger]

P.S. this is why I do NOT like to add the feature to remember the last user selection.

[love-linger]

If this happends again, you can try press the Fetch button, see if it starts directly. If so, it means the Ctrl keyup event is not handled by this app.

[albertodlc]

Ok thank you, I reinstalled the last public build and worked fine again, so I cannot test the fix with Github's actions last build, but thanks for the quick response.

I tried to replicate the error but I was not capable. As extra info, the only strange thing that I did before the checkout error was to stage the changes (without committing).

0. Previously mark the option Discard on a previous checkout
1. On the new branch. Make some changes. Stage those changes
2. Go to Histories and checkout to the new branch (I am not sure, but I think in this moment the popup did not ask for confirmation and executed the checkout with the previous settings - Discard)

I agree with you about this #748 (comment)