-
Notifications
You must be signed in to change notification settings - Fork 256
Update Russian translation - Welcome Page and top-level menus #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Russian translation - Welcome Page and top-level menus #1704
Conversation
691a2d3
to
64a08e0
Compare
src/Resources/Locales/ru_RU.axaml
Outdated
<x:String x:Key="Text.About.SubTitle" xml:space="preserve">Бесплатный графический клиент Git | ||
с открытым исходным кодом</x:String> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Раньше здесь работал автоперенос, насколько помню.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted
src/Resources/Locales/ru_RU.axaml
Outdated
<x:String x:Key="Text.Clone.AdditionalParam" xml:space="preserve">Параметры:</x:String> | ||
<x:String x:Key="Text.Clone.AdditionalParam.Placeholder" xml:space="preserve">Дополнительные аргументы клонирования (необязательно)</x:String> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Команда Клонировать репозиторий (Ctrl+N)
Я удалил точки, поскольку общепринятой практикой является не иметь конечных знаков препинания в плейсхолдерах. Также некоторые тексты подсокращены, чтобы влезать в отведенное место, пока не будет реализовано #1681. Так диалог выглядит сейчас:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Согласен. У меня порой привычка такая ставить точки.
Насчёт параметров, думаю, нужно обрезать что-то одно. Так как слова «расширенные» и «дополнительные» создают избыточность трактовки. Или вообще убрать эти слова... Всё равно понимается как дополнительные.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Текст в плейсхолдере я решил заменить на совсем явный "Аргументы git clone (необязательно)". Оно все равно нужно уже продвинутым (или на пути к ним) пользователям, так что пусть точно понимают, какую команду гуглить. "Параметры" тоже оставил в сокращенном виде, т.к. это самая длинная тут строчка и она уменьшает полезный размер всех полей
I don't understand Russian. Maybe I need @AquariusStar to help review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all good. I confirm the changes.
src/Resources/Locales/ru_RU.axaml
Outdated
@@ -5,15 +5,16 @@ | |||
|
|||
<x:String x:Key="Text.About" xml:space="preserve">О программе</x:String> | |||
<x:String x:Key="Text.About.Menu" xml:space="preserve">О SourceGit</x:String> | |||
<x:String x:Key="Text.About.SubTitle" xml:space="preserve">Бесплатный графический клиент Git с исходным кодом</x:String> | |||
<x:String x:Key="Text.About.SubTitle" xml:space="preserve">Бесплатный графический клиент Git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already add TextWrap=Wrap
attribute to display sub-title in About
page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. This will improve readability for other languages that may have longer text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, then I remove this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, then I remove this change
This part of the code can be removed because the author added a flag.
The following keys was reviewed: - Text.About.* - Text.Clone.* - Text.Hotkeys.* - Text.PageTabBar.* - Text.ScanRepositories.* - Text.SelfUpdate.* - Text.Welcome.*
64a08e0
to
a1916aa
Compare
<x:String x:Key="Text.Welcome.Clone" xml:space="preserve">Клонировать репозиторий</x:String> | ||
<x:String x:Key="Text.Welcome.Delete" xml:space="preserve">Удалить</x:String> | ||
<x:String x:Key="Text.Welcome.Delete" xml:space="preserve">Удалить...</x:String> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to mention those changes. I added ellipsis (...) for context menu items that does not execute immediately. This is a good tone that many applications follow (at least on Windows) to show the user, that potentially dangerous action won't be executed immediately.
Of course, there also some counterexamples, most famous is Windows Explorer. Its Delete (or Remove?) action doesn't have ellipsis. But I think with the ellipsis it will be better. I suggest to update other translations in the same way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting remark. I assume you mean that after pressing the command, a separate window appears asking for confirmation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm about this
This is update of Russian translation. Below the explanation for Russian speakers. They is useless for non-speakers, because they are unlikely to understand nuances. Below the explanations of some changes on Russian.