Skip to content

Tweak English translations. #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EreMaijala
Copy link
Contributor

  • Menu entries that require additional input end with ellipsis.
  • No blank space before ellipsis or colon.
  • A few minor tweaks e.g. to unify the style of adjacent choices.

While I'm not a native English speaker, I'd like to suggest some changes to make the English translation better follow en-US conventions as well as the recommended use of ellipses in most interface guidelines to indicate further dialog or such, as Apple puts it:

Append an ellipsis to a menu item’s label when the action requires more information before it can complete.

- Menu entries that require additional input end with ellipsis.
- No blank space before ellipsis or colon.
- A few minor tweaks e.g. to unify the style of adjacent choices.
@love-linger love-linger self-assigned this Jun 18, 2024
@love-linger love-linger added the enhancement New feature or request label Jun 18, 2024
@love-linger love-linger merged commit f9d62c5 into sourcegit-scm:develop Jun 18, 2024
love-linger added a commit that referenced this pull request Jun 18, 2024
* avoid highlight trailing ellipsis
* use WidthIncludingTrailingWhitespace instead of Width to keep original white space in translation
* add same modification on zh_CN and zh_TW
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants