Skip to content

Conversation

Noisyfox
Copy link

@Noisyfox Noisyfox commented Jul 4, 2024

This works much better on small screens when repo has lots of tags and branches

side_scroll

…ll screens when repo has lots of tags and branches
@love-linger
Copy link
Collaborator

If whole panel is scrollable, virtualizing will not work. This can cause stalling when displaying a large number of lists or tree nodes.

@love-linger
Copy link
Collaborator

for example, this is a user's repo from issue #215, which has 1900+ tags

image

@Noisyfox
Copy link
Author

Noisyfox commented Jul 4, 2024

Firstly the tags are not shown by default. Secondly they can always filter first, if they really have THAT many tags.

@Noisyfox
Copy link
Author

Noisyfox commented Jul 4, 2024

My main complatination is even ignore the tags, currently the branch list cannot be properly used on small screens.

@Noisyfox
Copy link
Author

Noisyfox commented Jul 4, 2024

At the moment, if you have a lot of local branches, you couldn't even see the remotes list nor submodules, not mention tags.
image

@love-linger
Copy link
Collaborator

love-linger commented Jul 4, 2024

At the moment, if you have a lot of local branches, you couldn't even see the remotes list nor submodules, not mention tags. image

This is indeed a disaster.

For a redesign, I would focus on two things

  • Need to support virtualization so that it doesn't get stuck when there are many items
  • Each group should be easily found at any time. For example, if you are scrolling through a list with 1000+ tags, you should also be able to see the grouping of local branches in that state, rather than having to scroll back.

@Noisyfox
Copy link
Author

Noisyfox commented Jul 4, 2024

At the moment, if you have a lot of local branches, you couldn't even see the remotes list nor submodules, not mention tags. image

This is indeed a disaster.

For a redesign, I would focus on two things

  • Need to support virtualization so that it doesn't get stuck when there are many items
  • Each group should be easily found at any time. For example, if you are scrolling through a list with 1000+ tags, you should also be able to see the grouping of local branches in that state, rather than having to scroll back.

Yeah agreed.

@love-linger
Copy link
Collaborator

I've pushed a new implementation for this. You can try it with latest develop branch

@love-linger love-linger closed this Jul 4, 2024
@Noisyfox
Copy link
Author

Noisyfox commented Jul 5, 2024

I've pushed a new implementation for this. You can try it with latest develop branch

That's much better now! Thanks! I can daily drive this instead of SourceTree now~ Fantastic work man!

@love-linger
Copy link
Collaborator

I've pushed a new commit for this feature. You can try the latest build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants