Fix foreground color in tooltip on primary button #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
love-linger
added a commit
that referenced
this pull request
Aug 21, 2024
* TextBlock may not be the direct child of Button, for example, it may wrapped by a StackPanel with icons. * Introduce another way to solve this problem
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue with the foreground color in the tooltip for the primary button. The problem was caused by an incorrect selector, which resulted in the tooltip text being displayed in the wrong color.
Before:
After:
I think this issue can be resolved simply by using the child combinator
>. However, because I'm not familiar with Avalonia UI, I hope this solution does not introduce any unintended side effects.