-
Notifications
You must be signed in to change notification settings - Fork 265
French translation improvements #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French translation improvements #424
Conversation
Should we invite the original authors to review? I'm Chinese and know nothing about French 🤣 |
@love-linger Let me finish my own review. You can invite when I will publish this PR ;) |
I'll take a look when it's ready |
I know nothing about French. @thomaschampagne @Jayllyz @UchiTesting Please merge your changes into one PR. I do NOT know which one to pick. |
Good evening. I would need to review that closely. Just a general note. There are also terms that are not translated because everybody knows their meaning. "Checkout" is one such term. As there is only one commit, I just don't know how to integrate the part I think is OK/Good from the rest. What I can propose is to note the list of translations that are actual improvements and ask for a new commit. Good evening. |
I am currently reviewing the merge. After all I think you should merge my version first then have @thomaschampagne create a new branch from develop branch with changes taking remarks that are about to come. This will be simpler. This is pretty long to check so I will go in batches. For now there is only one non legit string. Most are distributed between OK or questionnable. Just don't close this PR until I finish checking. Thanks. |
A 1st batch of review Legit/OK strings
Questionnable strings
Non legit strings
|
A 2nd batch of review Legit/OK strings
Questionnable strings
Non legit strings
|
Hello @thomaschampagne It is not complete yet, but there is enough to prepare one or several commits. I would appreciate you do not translate any new string from what is translated in the current state of your current PR. It is because I am tracking my review progress and I could miss things otherwise. Alternatively add the list of any newly translated string but it would be better to come with a future PR. Kind Regards. |
A 3nd batch of review Legit/OK strings
Questionnable strings
Non legit strings
|
Since the PR has conflicts with code in current |
I was waiting for any answer from this PR poster. |
My french translations improvements
I build and tested translations locally.