Improve macOS window control button colors for native appearance #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiahongHong
force-pushed
the
macos-buttons
branch
from
6ae8253 to
2b056ee
Compare
love-linger
added a commit
that referenced
this pull request
Sep 1, 2024
* move resources and styles for macOS caption button to `CaptionButtonsMacOS` because it is never used by others and should not been changed * add `IsCloseButtonOnly` property to `CaptionButtons` and `CaptionButtonsMacOS` and replace the controls in windows
love-linger
added a commit
that referenced
this pull request
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the colors of the macOS window control buttons (Close, Minimize, Maximize) in SourceGit to better match the native appearance.
Color Source
The colors were obtained by unpacking
/System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/Aqua.carandDarkAqua.carusing ThemeEngine. The colors were then measured using Digital Color Meter. Due to the pixelated nature of the images, there may be slight inaccuracies.Note: The button border remains set to
<Setter Property="Stroke" Value="#40000000"/>due to the difficulty in measuring the border color, which is very small, and I'm not sure starting from which version of macOS the maximize button's direction was rotated 90 degrees, so I didn't change it.Pressed Effect
The original buttons did not include a pressed state. I have now implemented this effect to enhance the user experience, as shown in this GIF.