feat: context menu for a commit in commit message #734
Conversation
When a commit message happens to contain a commit link and the user elects to right-click it, instead of navigating them to the commit, present a menu with options to navigate to it or to copy SHA.
`_lastHover` in the `if` is also swapped for `match`for consistency with the block body
|
Why not click the SHA, navigate to the target COMMIT then copy the SHA if it is the right one you want to copy after checking? |
* remove unnecessary namespace using * do NOT set tooltip currently, because CommitDetail.GetParent may cause UI lags and the tooltip DataTemplate is not provided. * add translations for zh_CN and zh_TW Signed-off-by: leo <longshuang@msn.cn>
Well, navigation cancels current selection, and you might need quite a bit of it in some cases. For instance I was trying to select some of the commits for cherry-pick from a list of cherry-picked commits elsewhere:
The ability to do so without navigation came in very handy. |
|
Why have you removed the tooltips for the commits? Are there some negative side effects that I didn't recognize? |
4 reasons:
|
|
Understood, thank you for explanation. Please let me know if you wish me to do some of that. |
Signed-off-by: leo <longshuang@msn.cn>
|
@czarkoff @love-linger bug_1125.mp4 |
|
Fixed by PR #741 |
When a commit message happens to contain a commit link and the user elects to right-click it, instead of navigating them to the commit, present a menu with options to navigate to it or to copy SHA.
I've reused translations for "Copy SHA." "Navigate to" remains untranslated in most locales, and the English wording choice might be questionable.