Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to enable rainbow progress bar #29

Merged
merged 5 commits into from
Dec 3, 2021
Merged

Add option to enable rainbow progress bar #29

merged 5 commits into from
Dec 3, 2021

Conversation

jan1na
Copy link
Contributor

@jan1na jan1na commented Dec 2, 2021

No description provided.

@alexstaeding
Copy link
Member

I recommend adding a user-facing flag to enable this, something like --progress=rainbow.

Flags are defined in Main.kt using the Clikt framework and could be passed to the ProgressBar constructor.

@alexstaeding alexstaeding added the semver:patch A patch change that does not affect API compatibility label Dec 2, 2021
@janbormet
Copy link
Contributor

I recommend adding a user-facing flag to enable this, something like --progress=rainbow.

Flags are defined in Main.kt using the Clikt framework and could be passed to the ProgressBar constructor.

I recommend this to be always enabled

@alexstaeding alexstaeding added semver:minor A minor change that adds features in a backwards compatible way and removed semver:patch A patch change that does not affect API compatibility labels Dec 3, 2021
@alexstaeding alexstaeding changed the title The progress bar is in rainbow colors which rotate. Add option to enable rainbow progress bar Dec 3, 2021
@alexstaeding alexstaeding added this to the v0.3 milestone Dec 3, 2021
alexstaeding
alexstaeding approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@alexstaeding alexstaeding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexstaeding alexstaeding merged commit d6ad0dc into sourcegrade:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexstaeding alexstaeding alexstaeding approved these changes

Assignees

@jan1na jan1na

Labels
semver:minor A minor change that adds features in a backwards compatible way
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jan1na @alexstaeding @janbormet