Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept old TU-IDs in the default studentID regex #51

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Accept old TU-IDs in the default studentID regex #51

merged 1 commit into from
Feb 2, 2022

Conversation

janbormet
Copy link
Contributor

Change the studentIdRegex in the default config to accept old and new TU-IDs.

@janbormet janbormet linked an issue Feb 2, 2022 that may be closed by this pull request
Do not assume new TU-IDs in moodle regex #14
Closed
@alexstaeding alexstaeding added this to the v0.4 milestone Feb 2, 2022
alexstaeding
alexstaeding approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@alexstaeding alexstaeding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexstaeding alexstaeding merged commit e4ad9c8 into master Feb 2, 2022
@alexstaeding alexstaeding deleted the fix/studentID-regex branch May 23, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexstaeding alexstaeding alexstaeding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Do not assume new TU-IDs in moodle regex
2 participants
@janbormet @alexstaeding