Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGM-6973 - Clean and update typography sitewide #7014

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Jun 18, 2024

This PR was created by GitStart to address the requirements from this ticket: SGM-6973.
This ticket was imported from: SGM-6973


Description:

Updates the site-wide typography according to the Figma link:

https://www.figma.com/design/o1QRtdQI0ozKq0n7ATrKlx/Marketing-DLS?node-id=8435-37157&t=O1E8a0nW4Zk4jl5Y-0

DEMO:

https://www.loom.com/share/908c184f87b742f096bba69e9b5fa5da?sid=48121504-c679-4a93-94c5-9b8f36def212

Test cases:

  • Old font families Source Sans, system fonts are removed

  • Update Tailwind font families to 'sans': Inter 'mono': Roboto mono 'display': Space Grotesk.

  • Letter spacing matches letter spacing on figma

  • Updated blog template type styles (H1, H2, H3) and added Callout according to the specs

Test plan:

  • Added text-blog-h1, text-blog-h2, text-blog-h3, text-blog-callout in the Global.css file and used the classes in the blog page headings
  • Added Font families and letter spacing are found in the tailwind.config file
  • Use element inspection tool in browser to check font details

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for sourcegraph ready!

Name Link
🔨 Latest commit f3ecd31
🔍 Latest deploy log https://app.netlify.com/sites/sourcegraph/deploys/667967ee5dffeb00087e4d71
😎 Deploy Preview https://deploy-preview-7014--sourcegraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gitstart-sourcegraph gitstart-sourcegraph self-assigned this Jun 18, 2024
@gitstart-sourcegraph gitstart-sourcegraph linked an issue Jun 18, 2024 that may be closed by this pull request
Copy link
Contributor

@traceyljohnson traceyljohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful job! Left a couple of comments.

tailwind.config.js Outdated Show resolved Hide resolved
tailwind.config.js Outdated Show resolved Hide resolved
Copy link
Contributor

@traceyljohnson traceyljohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra comments

src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/code-search.tsx Outdated Show resolved Hide resolved
src/components/Code-search/CodeSearchCard.tsx Outdated Show resolved Hide resolved
src/styles/globals.css Outdated Show resolved Hide resolved
src/styles/globals.css Outdated Show resolved Hide resolved
src/styles/globals.css Outdated Show resolved Hide resolved
@traceyljohnson
Copy link
Contributor

Also spotted this icon seems to actually not be a proper SVG, but an SVG containing a base64 encoded PNG. Could your team inspect SVGs whenever they export from Figma, to ensure this doesn't happen again? Attaching the proper SVG to this comment. Appreciate you!
CleanShot 2024-06-19 at 10 49 51@2x
Code-Search-product-icon

@gitstart-sourcegraph
Copy link
Contributor

Extra comments

Thanks @traceyljohnson
Will address these ASAP

@traceyljohnson traceyljohnson merged commit 432882d into main Jun 24, 2024
6 checks passed
@traceyljohnson traceyljohnson deleted the SGM-6973 branch June 24, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean and update typography sitewide
2 participants