This repository has been archived by the owner on Oct 29, 2021. It is now read-only.
add linting and data race testing to travis #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was throwing "crypto/x509: require a NULL parameters for RSA public keys."
heyitsanthony
force-pushed
the
travis-tests
branch
2 times, most recently
from
d002b4e
to
75d3808
Compare
Was causing failures on travis.
|
Thanks @heyitsanthony ! This looks great! 😄 (and apologies for the delayed review, I was on vacation when you sent this and missed the notification) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.