Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Can not type @ to include files in chat #2383

Closed
elemental-mind opened this issue Dec 14, 2023 · 4 comments · Fixed by #2558
Closed

bug: Can not type @ to include files in chat #2383

elemental-mind opened this issue Dec 14, 2023 · 4 comments · Fixed by #2558
Assignees
@abeatrix
Labels
bug Something isn't working clients/vscode

Comments

@elemental-mind
Copy link

elemental-mind commented Dec 14, 2023 •
edited
Loading

Version

v1.0.0
v1.1.1702572663

Describe the bug

When in the chat interface, I can not type @ to include files for context. Even though I type an @ no @ appears in the chat editor - and subsequently no files can be included.

I am working on a german keyboard (QWERTZ) so the keyboard combination should be [ALT GR] + [Q].

Current workaround is using the alt-code: [ALT] + ([NUM-6] + [NUM-4])

Expected behavior

When typing @ to have an @ appear in the chat window and subsequently get suggestions for files to include as context.

Additional context

There seems to be a similar issue with other foreign keyboards already posted on discord: https://discord.com/channels/969688426372825169/1179099930258833540
@elemental-mind elemental-mind added bug Something isn't working clients/vscode labels Dec 14, 2023
@elemental-mind
Copy link
Author

For context: OS is Win 10 Version 10.0.19045

@arafatkatze
Copy link
Contributor

As an additional note: I do not face this with my Latin American(Spanish) keyboard but I do face this with some other key combinations(Like make a new chat for example).

For new chat the normal symbols are ⌥ / but I also have to press shift coz that's how my keyboard works.

My recommendation is

  1. Go to keyboard shortcuts
image
  1. Go to record keys
image
  1. Record the exact keys that the cody command requires
  2. The search results will show you if there is something within your VScode settings that overrides those commands. And when you find something truly frivolous you can just delete that shortcut and when you do that the Cody shortcut takes over.

@abeatrix abeatrix self-assigned this Jan 3, 2024
@abeatrix abeatrix mentioned this issue Jan 3, 2024
Merged
@manfromtunis
Copy link

hello i'm having the same problem, ENG FR keyboard layouyt the usual alt + @ won't open the menu in vscode, but using ALT + 6 + 4 worked

abeatrix added a commit that referenced this issue Jan 4, 2024
@abeatrix
fix: only prevent default on Ctrl key combo (#2558)
60899dd 
Close #2383

The previous check for Ctrl or AltGraph being pressed was too broad and
prevented some default browser shortcuts from working properly, and
created blockers for users on different keyboard layouts

This fixes it by checking specifically for Ctrl keys combo only.

Alt + C is still prevented. 

## Test plan

<!-- Required. See
https://sourcegraph.com/docs/dev/background-information/testing_principles.
-->

1. Try using alt + key combos when focusing in input box - this should
now work
2. Try pressing alt + c when focusing in input box - this should open
the command menu
@elemental-mind
Copy link
Author

Thanks @abeatrix , just tried it and works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abeatrix abeatrix

Labels
bug Something isn't working clients/vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: only prevent default on Ctrl key combo sourcegraph/cody
4 participants
@elemental-mind @arafatkatze @manfromtunis @abeatrix