Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove params from logError verbose logging #1205

Merged
merged 2 commits into from
Sep 27, 2023
Merged

fix: remove params from logError verbose logging #1205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c0d2d
fix: remove params from logError verbose logging
abeatrix Sep 27, 2023
1be94fc
update changelog
abeatrix Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ Starting from `0.2.0`, Cody is using `major.EVEN_NUMBER.patch` for release versi

### Fixed

- Removed invalid variable from logs that stopped rate-limit errors from displaying properly. [pull/1205](https://github.com/sourcegraph/cody/pull/1205)

### Changed

- Moved "Insert at Cursor" and "Copy" buttons to the bottom of code blocks, and no longer just show on hover. [pull/1119](https://github.com/sourcegraph/cody/pull/1119)
Expand Down
2 changes: 1 addition & 1 deletion vscode/src/completions/get-inline-completions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export async function getInlineCompletions(params: InlineCompletionsParams): Pro
const error = unknownError instanceof Error ? unknownError : new Error(unknownError as any)

params.tracer?.({ error: error.toString() })
logError('getInlineCompletions:error', error.message, error.stack, { verbose: { params, error } })
logError('getInlineCompletions:error', error.message, error.stack, { verbose: { error } })
CompletionLogger.logError(error)

if (isAbortError(error)) {
Expand Down