-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: doc command #1273
fix: doc command #1273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the "if you run the /doc command and then reload VS code, your chat will start with the output of your last /doc command in chat view" part of this and works as expected 👍🏼 But I reckon let's leave the prompt changes to the other PR.
agree. this PR should not be merged until #1198 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback inline.
I think we should try to simplify this a bit—only strip one newline, not multiple ones; not prune human text from the transcript?
Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you!
Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
@dominiccooney thank you for your thoughtful review as always 🙇♀️ |
I noticed the
/doc
command built from the current main branch has the following issues:This PR fixes the issues listed above.
Also merged the prompt with the one tested by Tim in #1198
IMPORTANT: This PR depends on the prompt improvement made in #1198
Test plan
Cody>Document Code
Before
https://www.loom.com/share/c1d316d9031d4550952da81d5e5c61fd?sid=3c06e825-e6c3-4c43-a17b-e93f186947a3
before.pull_1273.mp4
After
https://www.loom.com/share/accef38b7f0f4d0c8e1ba8b89581acd2?sid=29fe90a4-9f5e-4a51-8c40-f4adad1c848f
after.pull_1273.mp4