Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete: add autocomplete.languages user setting #1290

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Autocomplete: add autocomplete.languages user setting #1290

merged 7 commits into from
Oct 3, 2023

Conversation

valerybugakov
Copy link
Member

Context

Screenshots

Screenshot 2023-10-03 at 11 45 04 Screenshot 2023-10-03 at 11 45 14

Test plan

Tested E2E locally + added unit tests.

@valerybugakov valerybugakov requested review from beyang and a team October 3, 2023 03:45
@valerybugakov valerybugakov self-assigned this Oct 3, 2023
@valerybugakov valerybugakov enabled auto-merge (squash) October 3, 2023 03:56
dominiccooney
dominiccooney approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but flatMap returning [] to skip items, and less duplication of those loops, would be nice.

vscode/src/completions/create-inline-completion-item-provider.ts Outdated Show resolved Hide resolved
vscode/src/completions/create-inline-completion-item-provider.ts Outdated Show resolved Hide resolved
vscode/src/completions/create-inline-completion-item-provider.ts Outdated Show resolved Hide resolved
vscode/src/testutils/mocks.ts Show resolved Hide resolved
@valerybugakov valerybugakov requested a review from a team October 3, 2023 05:50
dominiccooney
dominiccooney approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads like poetry. Great work.

@philipp-spiess philipp-spiess merged commit a3e0657 into main Oct 3, 2023
12 checks passed
@philipp-spiess philipp-spiess deleted the vb/autocomplete-languages branch October 3, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiccooney dominiccooney dominiccooney approved these changes

@philipp-spiess philipp-spiess philipp-spiess approved these changes

@umpox umpox umpox approved these changes

@beyang beyang Awaiting requested review from beyang

Assignees

@valerybugakov valerybugakov

Labels
autocomplete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VS Code: create a user setting to disable completions for specified languages
4 participants
@valerybugakov @dominiccooney @philipp-spiess @umpox