fix: unresponsive selections in custom command menu #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
commented
Oct 17, 2023
| @@ -285,14 +285,14 @@ export class CommandsController implements VsCodeCommandsController, vscode.Disp | |||
| const selected = await showCustomCommandMenu([...promptItems]) | |||
| const commandKey = selected?.description | |||
There was a problem hiding this comment.
Here we are looking for description when we are checking label below, which caused the issue because these options did not have description fieldss
philipp-spiess
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: https://sourcegraph.slack.com/archives/C05AGQYD528/p1697105184992049
This PR fixes the issuses reported by Philipp where `` does not work in Custom Commands Menu. This issue was caused by the previous update when
descriptionhas become a required field.descriptionfieldlast five used custom commandsnot showing up in the same menuThis fixes an issue where commands with null descriptions would not be run when selected.
Test plan
Custom CommandsConfigure Custom Commands...andNew Custom Command...These options should now work when building from this branch.
Other commands should still work as expected.