fix: smart selection not working on the first line of code #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiccooney
approved these changes
Oct 27, 2023
Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
burmudar
pushed a commit
that referenced
this pull request
Nov 21, 2024
Moving agent to [this commit ](38885b4) who has a parent which is the[ agent changes](#4073) from me ## Test plan Nothing to test here <!-- All pull requests REQUIRE a test plan: https://sourcegraph.com/docs/dev/background-information/testing_principles Why does it matter? These test plans are there to demonstrate that are following industry standards which are important or critical for our customers. They might be read by customers or an auditor. There are meant be simple and easy to read. Simply explain what you did to ensure your changes are correct! Here are a non exhaustive list of test plan examples to help you: - Making changes on a given feature or component: - "Covered by existing tests" or "CI" for the shortest possible plan if there is zero ambiguity - "Added new tests" - "Manually tested" (if non trivial, share some output, logs, or screenshot) - Updating docs: - "previewed locally" - share a screenshot if you want to be thorough - Updating deps, that would typically fail immediately in CI if incorrect - "CI" - "locally tested" -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: smart selection not working on the first line of code
This issue was caused by
!selection?.start.linein the smart selection function excluding the possibility ofselection?.start.line === 0(the vs code API returns the line number on display - 1, so line 1 in the editor would returns 0).This commit fixes that by explicitly checking selection.start.line is not null and is not equal to 0 before failing.
Test plan
Try running the
Generate Unit Testscommand on the first line of the file:After
You should be able to run the command and the expanded range will be selected for you automatically when available:
Before