feat: add context file via @ in chat input #1631

abeatrix · 2023-11-03T22:06:53Z

Continue from #1549
Close #1523

demo_at_file.mov

This adds PR support for passing context files to recipe from chat input. The context files are extracted from the codebase and passed to the recipe context.

Create context messages from context files
Generate display text including context file names
Add getTextEditorContentForContextFile method in editor to get content for context files
Update editor interface to support getting content for context files
Add ContextFile type to represent context files
Add userInputContextFiles property to RecipeContext for passing context files
Update RecipeContext to accept ContextFile[]
Generate context messages from ContextFile[]
Update chat question recipe to support getContextFilesContext
Pass editor context as ContextFile[] to custom prompt and chat question handler

This PR focuses on implementing the feature that allows users to add local workspace file via @ command via chat box.

Test plan

In the input box inside the new Chat view, add files from the current workspace using the @ command
- Typing @ will display a pop up where you can select files in the current workspace
- Typing @ without additional character will show a list of currently opened files for you to choose
- Typing @ follow by additional character will update the file list and display results that matches the file path and symbol names when available
- Allow you to attach multiple files via @
- Ask a question with a file attached using the @ command
  - Cody should have context about the file or symbol you attached using the @ command
  - The @-file is a link that's clickable in user's display text

abeatrix · 2023-11-04T02:11:46Z

@toolmantim this is ready for test 👍

umpox

Left some comments, have to drop off but will get back to this! Really cool to play around with and feels super powerful

Should the selector box show as soon as I start typing "@"? It feels like something isn't working because it doesn't show until I've typed a lot - an immediate indication that it is searching would be useful!

lib/shared/src/chat/prompts/get-display-text.ts

lib/shared/src/editor/index.ts

agent/src/editor.ts

lib/shared/src/chat/recipes/custom-prompt.ts

lib/shared/src/codebase-context/messages.ts

vscode/src/editor/utils/editor-context.ts

vscode/src/chat/MessageProvider.ts

vscode/src/editor/utils/editor-context.ts

umpox · 2023-11-07T17:05:07Z

vscode/src/editor/utils/editor-context.ts

+    // NOTE: Symbol search is resources extensive, so only search if query is long enough
+    // Five is an arbitrary minimum length
+    if (!query.trim() || query.trim().length < 5) {
+        return []
+    }


Have we considered using symf as an option for this? This would give us a more advanced way of finding symbols, which might be awesome when trying this out.

Might also be faster? @beyang

Yea we can always add additional context here. For v1 the main goal was to support @ file but once we have other sources of context that are more reliable we can always update this!

Co-authored-by: Tom Ross <tom@umpox.com>

…ph/cody into bee/user-input-context

abeatrix · 2023-11-10T03:47:00Z

@umpox @valerybugakov can i get your review if you've got a chance, please? 🙇‍♀️

umpox · 2023-11-10T12:55:08Z

@abeatrix Looking now, thanks for making those changes!

AtCommand1252.mov

I noticed some unexpected behavior when trying it out 🤔 :

The selection seems to get stuck between the bottom two items and ignores the top two at the start of the video. Unsure why this happens, we should either not show irrelevant items or make sure we can still select them.
When I select getRerankW it doesn't seem to input the fill symbol into the chat.
- Edit: seems this only happens on keypress, not mouse click? Might help with debugging
I tried to select the same getRerankWithLog symbol again, and it shows the very first time (when I type @g but then it disappears and I can't seem to get it back)

umpox

Noticed some unexpected behavior and left a few comments, feels really great aside from that! Approving given this is behind a flag and don't want to block you!

vscode/src/chat/MessageProvider.ts

vscode/src/editor/utils/editor-context.ts

umpox · 2023-11-10T13:06:22Z

vscode/src/editor/utils/editor-context.ts

+                (symbol.kind === vscode.SymbolKind.Function ||
+                    symbol.kind === vscode.SymbolKind.Method ||
+                    symbol.kind === vscode.SymbolKind.Class) &&


Possibly if we support a way like prefixing the query with # we would want to remove this filter so a user could still use a symbol like a TS interface or w/e

abeatrix · 2023-11-10T15:41:48Z

@umpox Thanks for testing it so throughly, really appreciate your help and feedback here 🙇‍♀️ Will make sure the issue is fixed before i merge anything, thank you!

update

The issue is now fixed

Screen.Recording.2023-11-10.at.2.19.00.PM.mov

wip: feat: add context file via input support

28b703e

abeatrix requested a review from toolmantim November 4, 2023 02:11

update tests and folders

14ec4b5

abeatrix changed the title ~~wip: feat: add context file via input support~~ feat: add context file via @ in chat input Nov 6, 2023

abeatrix marked this pull request as ready for review November 6, 2023 17:54

abeatrix added 2 commits November 6, 2023 19:05

update: handle context files in editor

455f447

Merge branch 'main' into bee/user-input-context

933a206

abeatrix requested a review from a team November 7, 2023 03:13

remove displayName field

a0c2aff

umpox reviewed Nov 7, 2023

View reviewed changes

abeatrix and others added 5 commits November 7, 2023 10:22

Apply suggestions from code review

ca86126

Co-authored-by: Tom Ross <tom@umpox.com>

fix code review changes

61f81b5

Merge branch 'main' into bee/user-input-context

7e34390

Add ContextFileType to ContextFile

f0dd46b

update selector component position

f2241d6

abeatrix requested review from umpox and a team November 8, 2023 17:21

abeatrix added 9 commits November 8, 2023 16:15

add type and source to local context

66e772b

Merge branch 'main' into bee/user-input-context

8998b72

add debounce to file search

5137db4

Merge branch 'bee/user-input-context' of https://github.com/sourcegra…

1c905a9

…ph/cody into bee/user-input-context

Update header title

e321fb7

Fix display text function names

054ce7f

fix tests

4b6f537

Merge branch 'main' into bee/user-input-context

7382154

show current open tab files on empty query

e4a0761

umpox approved these changes Nov 10, 2023

View reviewed changes

abeatrix added 2 commits November 10, 2023 14:24

fix keypress handling issue

a215ddb

update changelog

7b2761a

abeatrix merged commit 0e0574f into main Nov 10, 2023
13 checks passed

abeatrix deleted the bee/user-input-context branch November 10, 2023 23:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add context file via @ in chat input #1631

feat: add context file via @ in chat input #1631

abeatrix commented Nov 3, 2023 •

edited

Loading

abeatrix commented Nov 4, 2023

umpox left a comment •

edited

Loading

umpox Nov 7, 2023

abeatrix Nov 8, 2023

abeatrix commented Nov 10, 2023

umpox commented Nov 10, 2023 •

edited

Loading

umpox left a comment

umpox Nov 10, 2023

abeatrix commented Nov 10, 2023 •

edited

Loading

feat: add context file via @ in chat input #1631

feat: add context file via @ in chat input #1631

Conversation

abeatrix commented Nov 3, 2023 • edited Loading

Next

Test plan

abeatrix commented Nov 4, 2023

umpox left a comment • edited Loading

Choose a reason for hiding this comment

umpox Nov 7, 2023

Choose a reason for hiding this comment

abeatrix Nov 8, 2023

Choose a reason for hiding this comment

abeatrix commented Nov 10, 2023

umpox commented Nov 10, 2023 • edited Loading

umpox left a comment

Choose a reason for hiding this comment

umpox Nov 10, 2023

Choose a reason for hiding this comment

abeatrix commented Nov 10, 2023 • edited Loading

update

abeatrix commented Nov 3, 2023 •

edited

Loading

umpox left a comment •

edited

Loading

umpox commented Nov 10, 2023 •

edited

Loading

abeatrix commented Nov 10, 2023 •

edited

Loading