Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VScode: Do not toggle "Enhanced context" off automatically. #2069

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

dominiccooney
Copy link
Contributor

This also sets the RUST_LIB_BACKTRACE=0 environment variable when spawning cody-engine, unblocking local embeddings index generation on macOS. See issue 138 in another place.

Fixes #1971

Test plan

https://www.loom.com/share/d5585f7cce3442b89cd7e60b402c5881

Manual test:

  1. Enable the new "panel" chat UI.
  2. Open a repository that has embeddings, for example github.com/sourcegraph/sourcegraph
  3. Start a new chat, chat about it. Enhanced context should not toggle off automatically.
  4. Manually toggle enhanced context off and chat. Embeddings results should not be included automatically.

@dominiccooney dominiccooney enabled auto-merge (squash) December 4, 2023 04:06
Copy link
Contributor

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the context button no longer toggles off ✅

I couldn't verify the bfg change, but I did get this hang when I sent the message:

Screenshot 2023-12-04 at 3 15 37 pm

Reloading the window got the first message through, but then I think bfg shut down again and chat responses once again hung:

Screenshot 2023-12-04 at 3 18 41 pm

@dominiccooney dominiccooney merged commit b45cef5 into main Dec 4, 2023
13 checks passed
@dominiccooney dominiccooney deleted the dpc/do-not-toggle-context-off-automatically branch December 4, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: enhanced context button shouldn't automatically toggle off
2 participants