Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent: fix bug causing recording files to not remove unused files #2926

Merged
merged 1 commit into from
Jan 29, 2024

Commits on Jan 29, 2024

  1. Agent: fix bug causing recording files to not remove unused files

    Previously, the HTTP recording file kept growing bigger and bigger even
    for PRs where we didn't add new requests and we had enabled the setting
    `keepUnusedRequests: false`, which should remove entries for unused
    requsts. Turns out that we were parsing the
    `KEEP_UNUSED_RECORDINGS=false` environment variable as the string
    value `"false"`, which is truthy. This PR fixes the problem so that we
    now correctly remove unused recordings.
    olafurpg committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    396ed9a View commit details
    Browse the repository at this point in the history