Agent: fix bug causing recording files to not remove unused files #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the HTTP recording file kept growing bigger and bigger even for PRs where we didn't add new requests and we had enabled the setting `keepUnusedRequests: false`, which should remove entries for unused requsts. Turns out that we were parsing the `KEEP_UNUSED_RECORDINGS=false` environment variable as the string value `"false"`, which is truthy. This PR fixes the problem so that we now correctly remove unused recordings.
cbart
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the HTTP recording file kept growing bigger and bigger even for PRs where we didn't add new requests and we had enabled the setting
keepUnusedRequests: false, which should remove entries for unused requsts. Turns out that we were parsing theKEEP_UNUSED_RECORDINGS=falseenvironment variable as the string value"false", which is truthy. This PR fixes the problem so that we now correctly remove unused recordings.Test plan
Green CI.