Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: Fix "Ask Cody to Explain" #3015

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Chat: Fix "Ask Cody to Explain" #3015

merged 8 commits into from
Feb 5, 2024

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Feb 2, 2024

Description

  • Pass the correct arguments to the cody.action.chat command
  • Add type safety to avoid this mistake again

closes #2970

Test plan

  1. Try "Ask Cody to Explain"
  2. Check there is no error

@vadi2
Copy link

vadi2 commented Feb 2, 2024

Is there an easy way to test this?

@umpox
Copy link
Contributor Author

umpox commented Feb 2, 2024

@vadi2 If you want to run this locally, you can checkout the branch locally and follow these docs: https://github.com/sourcegraph/cody/blob/main/doc/dev/index.md

I'll add some integration tests too :)

@vadi2
Copy link

vadi2 commented Feb 2, 2024

% asdf install
Install plugins first to be able to install tools

Which plugins should I install?

@umpox
Copy link
Contributor Author

umpox commented Feb 2, 2024

@vadi2 Try this quickstart from the repo root:
pnpm install && pnpm build && cd vscode && pnpm run dev

That should work if you have NodeJS installed.

I've added an e2e test for this too

@vadi2
Copy link

vadi2 commented Feb 2, 2024

No luck testing it - same issue in the 2nd vscode instance that pops up when I run the Launch VS Code Extension (Desktop) task, but it could be that I'm doing something wrong.

First time I launch it says:

Actual command not found, wanted to execute cody.action.chat /14

Any follow-up attempts yield this:

Cannot read properties of undefined (reading 'match')

Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the Ask Cody to Explain works for me:
image

Also updated the failing e2e test that hopefully helps!

@umpox umpox merged commit 4cba481 into main Feb 5, 2024
14 of 15 checks passed
@umpox umpox deleted the tr/fix-cody-explain branch February 5, 2024 10:14
@umpox
Copy link
Contributor Author

umpox commented Feb 5, 2024

@vadi2 Might have been an issue with our local flow. We need to do a check on the instructions for first clones.

I've merged this now so will ensure this is included in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: errors when using "ask cody to explain" an error
3 participants