-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete: Add option to disable inside code comments #3049
Conversation
Ah we do it manually in tests via this I seeeee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fabulous!
Can we get this for jetbrains IDEs? Comment completion really grinds my gears as I use it to brainstorm :| |
@philipp-spiess any chance you can point me how to use this setting in Jetbrains IDEs? |
@sjurgis I'll defer to @pkukielka but chances are we don't have the setting there yet. |
We do not support it yet but it should be a quick job to add it. |
@taylorsperry @kalanchan that would be a nice differentiator as no other assistant supports this... |
Closes #3038
Adds a new user config option to prevent completions inside code comments.
@valerybugakov I didn't get the test to run since the intent detection is never run because the parser cache is always empty even though I ran
initTreeSitterParser()
. Do you know how we can get this enabled in unit tests? I would expect a call toprovideInlineCompletions
to preload the parser cache if we have calledinitTreeSitterParser
before but I don't think this happens right now. Perhaps because we query it before the stuff insideget-inline-completions
but we do call into tree sitter before that so I think this should work. 😄Test plan
Screen.Recording.2024-02-06.at.13.09.59.mov