Command: remove slashes from commands #3061
Conversation
|
Design wise we want to have it match the commands treeview. Could we update both the treeview and the command menu to match this? |
@toolmantim sure can do! Forgot we have a figma for this so this would make things a lot easier, thanks! |
|
@toolmantim updated and ready for review! |
abeatrix
changed the title
There was a problem hiding this comment.
This is great!
A few small changes if we could:
- "New Chat" from the quickpick should act the same as "New Chat" in the review (open a new chat tab)
- Could we add the keyboard shortcuts for "New Chat" and "Edit Code" to the quickpick item descriptions?
- If there are no custom commands, can we make "Custom Commands" quickpick item & treeview item go directly to the "Configure Custom Commands…" and skip the empty-ish middle quickpick?
One bug:
- In the quickpick "Custom Commands" > "Configure Custom Commands…" both the "New Custom Command..." and "Open Custom Commands Documentation" items don't seem to work
|
@toolmantim updated based on your suggestions and fixed the bug:
|
There was a problem hiding this comment.
Nice! Two non-blocking things…
If you start typing "New" you end up seeing duplicates. I'd suggest we always exclude the "New Chat (shortcut)" and "Edit Code (shortcut)" items when you start filtering/typing… because they're always going to be there as "Start a new chat" and "Start a new edit" anyhow.
Also when you filter in custom commands we probably don't want to show these last 3 items, just the filtered custom commands (or nothing if no matches):
|
Does this binding actually exist? I can't get it to trigger:
If it doesn't exist, we can just remove that shortcut label for now. |
it does exist! I just fixed this and the bugs you found. Will update the e2e tests tomorrow to cover these cases before I finalize the PR tomorrow, thanks for taking the time to review and test this PR out! |
| * cody command, e.g. '/ask' | ||
| * @deprecated Use 'commandKey' instead. | ||
| */ | ||
| slashCommand?: string |
CLOSE #1730
Remove slashes from command names and implemented design from https://www.figma.com/file/jEsnzgsf0hNuJbqB9pKaGm/VS-Code---Cody---Commands-up-front-and-ChatGPT%2B%2B?type=design&node-id=1550-62492&mode=design&t=qdjbLWsl9qHq578p-4
Main Commands Menu
Custom Commands Menu
Test plan
Updated all current tests.
Screen.Recording.2024-02-09.at.7.49.47.AM.mov
Before