remove needless command:_cody.vscode.open wrapping for https? URLs #3437
+61
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
force-pushed
the
sqs/no-wrap-https-urls
branch
from
bca9cc6
to
c14cbec
Compare
burmudar
approved these changes
Mar 17, 2024
sqs
force-pushed
the
sqs/no-wrap-https-urls
branch
from
c14cbec
to
ab824df
Compare
Now, links in human messages open in the web browser when clicked, instead of showing a VS Code "do you trust this domain?" dialog.
sqs
force-pushed
the
sqs/no-wrap-https-urls
branch
from
ab824df
to
eb8f45c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, links in human messages open in the web browser when clicked, instead of showing a VS Code "do you trust this domain?" dialog.
Test plan
CI; e2e tests handle these cases