Add autoresizing and command button to chat input #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolmantim
force-pushed
the
tl/autoresize-chat-textarea
branch
from
cf1990c
to
f118f21
Compare
toolmantim
changed the title
dominiccooney
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
You could mention #613 in your description.
Looks splendid. Some feedback inline for your consideration.
| @@ -9,7 +9,7 @@ test('open the Custom Commands in sidebar and add new user recipe', async ({ pag | |||
|
|
|||
| await expect(sidebar.getByText("Hello! I'm Cody.")).toBeVisible() | |||
|
|
|||
| await sidebar.getByRole('textbox', { name: 'Text area' }).fill('/') | |||
| await sidebar.getByRole('textbox', { name: 'Chat message' }).fill('/') | |||
There was a problem hiding this comment.
Kudos for writing useful accessibility role names.
Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revamps the chat input with better styling (high contrast outline support, proper border radius, etc), autoresizing support for long lines and narrow screens, and a command button.
Screen.Recording.2023-08-18.at.12.18.10.am.mov
Fixes #613
Test plan