Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github.com/sourcegraph/go-diff import path instead of custom sourcegraph.com/... import path #30

Merged
merged 1 commit into from
Mar 24, 2019

Conversation

sqs
Copy link
Member

@sqs sqs commented Mar 24, 2019

No description provided.

@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@dee78e5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage          ?   26.91%           
=========================================
  Files             ?        5           
  Lines             ?     1133           
  Branches          ?        0           
=========================================
  Hits              ?      305           
  Misses            ?      784           
  Partials          ?       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee78e5...de643bf. Read the comment docs.

@sqs sqs merged commit c825d9a into master Mar 24, 2019
@dmitshur
Copy link
Contributor

README still says go get -u sourcegraph.com/sourcegraph/go-diff/diff and uses the previous import path in the godoc.org badge. Is that unintentional?

sqs added a commit that referenced this pull request Mar 24, 2019
@sqs sqs mentioned this pull request Mar 24, 2019
sqs added a commit to sourcegraph/sourcegraph-public-snapshot that referenced this pull request Mar 24, 2019
@sqs sqs deleted the github-import-path branch March 24, 2019 22:13
@sqs
Copy link
Member Author

sqs commented Mar 24, 2019

(#30 (comment) fixed in #32, thanks!)

sqs added a commit to sourcegraph/sourcegraph-public-snapshot that referenced this pull request Mar 24, 2019
dmitshur added a commit to shurcooL/home that referenced this pull request Mar 25, 2019
slimsag pushed a commit to sourcegraph/go-vcs that referenced this pull request Apr 9, 2019
dmitshur added a commit to shurcooL-legacy/Conception-go that referenced this pull request Apr 15, 2019
dmitshur added a commit to shurcooL-legacy/Conception-go that referenced this pull request Apr 15, 2019
DABH pushed a commit to DABH/changes that referenced this pull request May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants