Clarify canonical import path, fix broken links. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The canonical import path for this package appears to be "sourcegraph.com/sourcegraph/go-diff/diff", not "github.com/sourcegraph/go-diff/diff". Add an import path comment to enforce and document this. Also mention the import path in README, so there's no need to guess what it actually is. Fix broken views counter image. Fix broken definition link. Add Travis build status badge. Update Travis Go to current version.
dmitshur
force-pushed
the
clarify-canonical-import-path
branch
from
696c4c8 to
2d6df58
Compare
Due to the vanity import path, we need to move the package into the correct location inside GOPATH workspace.
This is a quick hack. The correct solution will be to fix tests so they pass regardless of user's timezone. See issue #6.
sqs
added a commit
that referenced
this pull request
May 15, 2015
Clarify canonical import path, fix broken links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourcegraph.com/sourcegraph/go-diff/diff, notgithub.com/sourcegraph/go-diff/diff. Add an import path comment to enforce and document this. Also mention the import path in README, so there's no need to guess what it actually is.diff.FileDiff