Skip to content

Update to latest golang image and go release #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

Update to latest golang image and go release #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bd21af
Update to latest golang image and go release
willdollman Aug 18, 2025
c68b394
Merge branch 'main' into will/update-base-image-20250818
antonsviridov-src Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
golang 1.24.6
golang 1.25.0
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@
# <other stuff to ignore>
# And use this digest in FROM

ARG base_sha=39d9e7d9c5d9c9e4baf0d8fff579f06d5032c0f4425cdec9e86732e8e4e374dc
ARG base_sha=74908ad827a5849c557eeca81d46263acf788ead606102d83466f499f83e35b1

FROM golang:1.24.3@sha256:${base_sha} AS builder
FROM golang:1.25.0-bookworm@sha256:${base_sha} AS builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willdollman why did we switch from the no-suffix image to one with the -bookworm suffix?


COPY . /sources
WORKDIR /sources
RUN go build -o scip-go ./cmd/scip-go

# Keep in sync with builder image
FROM golang:1.24.3@sha256:${base_sha} AS final
FROM golang:1.25.0-bookworm@sha256:${base_sha} AS final

COPY --from=builder /sources/scip-go /usr/bin/
ENV GOTOOLCHAIN=auto
Expand Down