Make compiler plugin work with Java 17 #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
changed the title
Previously, the SemanticDB compiler plugin crashed when compiling code with Java 17 because it was using private APIs. This commit refactors the code to use blessed public APIs so that compiling with Java 17 works successfully. This commit only fixes the issues for the compiler plugin. Running `lsif-java index` on Gradle/Maven projects will still fail on Java 17 projects since we don't automatically configure the requried `--add-exports` flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the SemanticDB compiler plugin crashed when compiling code
with Java 17 because it was using private APIs. This commit refactors
the code to use blessed public APIs so that compiling with Java 17 works
successfully.
This commit only fixes the issues for the compiler plugin. Running
lsif-java indexon Gradle/Maven projects will still fail on Java 17projects since we don't automatically configure the requried
--add-exportsflags.Towards #263