Emit additional occurrences for synthetic Scala symbols #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I manually tested that this fixes the issue by uploading an index and using "goto definition". Links
|
Fixes sourcegraph#397 Fixes sourcegraph#396 Previously, "goto defintion" did not work for synthetic symbols such as case class companion objects or var setter methods. Now, lsif-java emits synthetic occurrences for these symbols so that "goto definition" works as expected.
olafurpg
force-pushed
the
synthetic-symbols
branch
from
1e779f0 to
23c3387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397
Fixes #396
Previously, "goto defintion" did not work for synthetic symbols such as
case class companion objects or var setter methods. Now, lsif-java emits
synthetic occurrences for these symbols so that "goto definition" works
as expected.