Skip to content

chore(ci): align usage of setup-java #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2022
Merged

chore(ci): align usage of setup-java #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
313e777
chore(ci): align usage of setup-java
ckipp01 Aug 16, 2022
ed16cb2
Merge branch 'main' into setupJava
olafurpg Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ jobs:
java: [8, 17]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v1
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
cache: 'sbt'
java-version: ${{ matrix.java }}
- uses: actions/setup-go@v2
with:
Expand All @@ -41,5 +43,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: olafurpg/setup-scala@v13
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: 17
cache: 'sbt'
- run: sbt checkAll
6 changes: 5 additions & 1 deletion .github/workflows/mdoc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ jobs:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: olafurpg/setup-scala@v13
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: 8
cache: 'sbt'
- run: sbt docs/docusaurusPublishGhpages
env:
GIT_DEPLOY_KEY: ${{ secrets.GIT_DEPLOY_KEY }}
6 changes: 5 additions & 1 deletion .github/workflows/release-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ jobs:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: olafurpg/setup-scala@v13
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: 8
cache: 'sbt'
- uses: docker/setup-buildx-action@v1
- name: Login to DockerHub
uses: docker/login-action@v1
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/release-maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ jobs:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: olafurpg/setup-scala@v13
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: 8
cache: 'sbt'
- name: Publish ${{ github.ref }}
run: sbt ci-release
env:
Expand Down
24 changes: 15 additions & 9 deletions .github/workflows/sourcegraph.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,30 @@ on:
push:
branches:
- main
- olafurpg/lets-go
pull_request:

pull_request:

jobs:
scip:
runs-on: ubuntu-latest
name: "Upload SCIP"
steps:
- uses: actions/checkout@v2
- uses: olafurpg/setup-scala@v13
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: 8
cache: 'sbt'

- uses: actions/setup-go@v2
with:
go-version: "1.15.6"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is go actually needed? I know in my uploads I don't include this and it seems to work fine?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a remnant from the time when we build src from source. If CI is green without this step then it's fine to remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 I'll send in another pr after this one and double-check. I don't want to edit this one again because I opened it before my first pr was merged, so you'll have to keep clicking run 😆 . If I open another I should be able to see the result and change if necessary.


- name: Install src
run: yarn global add @sourcegraph/src

- name: sbt sourcegraphUpload
run: |
mkdir -p bin
curl -L https://sourcegraph.com/.api/src-cli/src_linux_amd64 -o bin/src
chmod +x bin/src
export PATH="$PATH:$PWD/bin"
sbt sourcegraphUpload
run: sbt sourcegraphUpload

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}