[scip-kotlin] Use the correct linguist language alias for Kotlin for markdown syntax highlighting #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub-embedded syntax highlighting for markdown uses `linguist` to detect which language to use. For Kotlin there's no alias `kt` so syntax highlighting doesn't work. Use 'kotlin' to correctly pick up the language of the signature blocks. c.f. https://github.com/github-linguist/linguist/blob/master/lib/linguist/languages.yml#L3660 https://github.com/github-linguist/linguist/blob/master/lib/linguist/languages.yml#L3660 Test plan: - tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub-embedded syntax highlighting for markdown uses
linguistto detect which language to use. For Kotlin there's no aliasktso syntax highlighting doesn't work. Use 'kotlin' to correctly pick up the language of the signature blocks.c.f. https://github.com/github-linguist/linguist/blob/master/lib/linguist/languages.yml#L3660 https://github.com/github-linguist/linguist/blob/master/lib/linguist/languages.yml#L3660
Test plan
reindex and check correct code is used.
Regenerate snapshot tests (how?)