Add new LSIF indexer with testing infrastructure #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add indexer implementation in the `src/` directory - Add config files for linting, formatting and testing - Add snapshot tests in the `snapshots/` directory
olafurpg
changed the title
olafurpg
force-pushed
the
new-start
branch
3 times, most recently
from
9fafd30 to
4b633e8
Compare
olafurpg
commented
Feb 24, 2022
There was a problem hiding this comment.
@varungandhi-src Thank you for the fantastic code review! I incorporated almost all of the suggestion and the resulting code is a lot cleaner. I'm sorry for the super slow response on this.
I resolved most of the comments without replying because the GitHub PR UI didn't allow me to reply from the "Conversation" view, and the "Files" view was not loading for me.
I have a few more things to address before this is ready for merge.
varungandhi-src
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/directorysnapshots/directory