Fix panics from symbolParserV2 #338
Merged
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varungandhi-src
approved these changes
Sep 23, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added test case contains an escaped multi-byte string that's valid UTF8 that caused a panic before the fix. The fix applied is to advance the entire multi-byte sequence instead of capping it to a single byte.
This caused a few other test failures, namely because we were validating unescaped identifiers were valid UTF8 where elsewhere we assume they're ASCII. The follow-up fix applied was to treat these in a uniform way.
Please let me know if I've misunderstood the original purpose of the removed
minguard.