Skip to content

Conversation

jupblb
Copy link
Member

@jupblb jupblb commented Sep 29, 2025

Running go test ./... on main ends up with the following error:

~> go test ./...
# golang.org/x/tools/internal/tokeninternal
../../../.local/share/go/pkg/mod/golang.org/x/tools@v0.17.0/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64)
FAIL	github.com/sourcegraph/scip/bindings/go/scip [build failed]
ok  	github.com/sourcegraph/scip/bindings/go/scip/internal	0.990s
?   	github.com/sourcegraph/scip/bindings/go/scip/internal/shared	[no test files]
ok  	github.com/sourcegraph/scip/bindings/go/scip/memtest	1.261s
?   	github.com/sourcegraph/scip/bindings/go/scip/speedtest	[no test files]
ok  	github.com/sourcegraph/scip/bindings/go/scip/testutil	0.428s
FAIL	github.com/sourcegraph/scip/cmd/scip [build failed]
?   	github.com/sourcegraph/scip/cmd/scip/tests/reprolang/bindings/go/repro	[no test files]
ok  	github.com/sourcegraph/scip/cmd/scip/tests/reprolang/src	0.560s
FAIL

This was fixed mainly by updating golang.org/x/tools.

We explicitly require go v1.24.1 (instead of v1.24.0) because of Sonic requirement.

Test plan

N/A

- Fixed go test ./...
- Update golang.org/x/tools from v0.17.0 to v0.37.0
- Update bytedance/sonic from v1.12.5 to v1.14.1 to fix Go 1.24+ compatibility
- Fix non-constant format string issues in tests
- Upgrade to Go 1.24.1 (required for sonic v1.14.1 compatibility)
@jupblb jupblb self-assigned this Sep 29, 2025
@jupblb jupblb added bug Something isn't working team/graph graph/scip labels Sep 29, 2025
Copy link
Contributor

@varungandhi-src varungandhi-src left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but generally we support 2 major Go versions, so I think we shouldn't bump beyond this until Go 1.27 is released.

@jupblb jupblb merged commit fc864ca into main Sep 29, 2025
2 checks passed
@jupblb jupblb deleted the michal/fix-test branch September 29, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working graph/scip team/graph

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants