Skip to content

Conversation

varungandhi-src
Copy link
Contributor

@varungandhi-src varungandhi-src commented Sep 22, 2022

Without this, modeling multiple inheritance (or single inheritance with mixins) is unnecessarily painful.

Test plan

  • Going to see if the code navigation works as expected in an SG instance with the new relationships statement in repro, which allows adding a relation to a symbol which lacks a definition.

@varungandhi-src
Copy link
Contributor Author

Looks like this does have the desired effect. 🎉

@varungandhi-src varungandhi-src changed the title WIP: Add is_definition. scheme: Add is_definition relationship Sep 23, 2022
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I see the hover is empty, should we add is_hover as well?

@varungandhi-src
Copy link
Contributor Author

varungandhi-src commented Sep 23, 2022

IIUC, the hover is empty because I set the documentation to be blank. So I don't quite get what is_hover would solve... If A is a definition for B, isn't the desired behavior that you show hover docs of A when you hover over B? Or you could supply hover docs for B in B's symbol information if you wanted that to be the case.

@varungandhi-src
Copy link
Contributor Author

Let's merge this for now so that I can start using it in scip-ruby. We can add is_hover later too.

@varungandhi-src varungandhi-src merged commit ae09e3b into main Sep 23, 2022
@varungandhi-src varungandhi-src deleted the vg/add-is-definition branch September 23, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants