Change "Blame:" to "Author:" in status bar for friendlier language #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkandala
approved these changes
Apr 14, 2021
|
@tjkandala CI shows up as failed but doesn't link to any actual build. Could you investigate this (assuming extensibility owns this repo)? We might want to migrate this repo to GitHub Actions given Travis is unreliable. |
|
@felixfbecker I've migrated to GitHub Actions in #197, I'll rebase this PR onto master and merge + publish it. |
tjkandala
force-pushed
the
friendlier-language
branch
from
e2a7de1 to
34108c8
Compare
tjkandala
reviewed
May 27, 2021
| @@ -204,7 +204,7 @@ export const getBlameStatusBarItem = ({ | |||
| ) | |||
|
|
|||
| return { | |||
| text: `Blame: ${username}${displayName}, ${distance}`, | |||
| text: `Author: ${username}${displayName}, ${distance}`, | |||
There was a problem hiding this comment.
Turns out we needed to update the tests too
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 47.58% 47.58%
=======================================
Files 4 4
Lines 124 124
Branches 25 25
=======================================
Hits 59 59
Misses 65 65
Continue to review full report at Codecov.
|
|
Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is always shown in the status bar, which comes with a negative connotation for any code that is being viewed (as someone is to be blamed for it). It's more neutral to state that this is the "author" of the code, without implying they are to be "blamed" for anything (even if the underlying Git CLI command is called
git blame).