Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Commit

Permalink
symbols: remove unused channel parseRequests (#61718)
Browse files Browse the repository at this point in the history
We can remove it since it is only ever created and then closed, never
read or written to. It seems like at some point we moved to using
parseRequestOrErrors and didn't remove parseRequests.

Test Plan: go test
  • Loading branch information
keegancsmith authored Apr 9, 2024
1 parent fe2e805 commit 2ab1574
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions cmd/symbols/parser/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,12 @@ func (p *parser) Parse(ctx context.Context, args search.SymbolsParameters, paths
}()

var (
wg sync.WaitGroup // concurrency control
parseRequests = make(chan fetcher.ParseRequest, p.requestBufferSize) // buffered requests
symbolOrErrors = make(chan SymbolOrError) // parsed responses
totalRequests, totalSymbols uint32 // stats
wg sync.WaitGroup // concurrency control
symbolOrErrors = make(chan SymbolOrError) // parsed responses
totalRequests, totalSymbols uint32 // stats
)

defer func() {
close(parseRequests)

go func() {
defer func() {
endObservation(1, observation.Args{Attrs: []attribute.KeyValue{
Expand Down

0 comments on commit 2ab1574

Please sign in to comment.