Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Remove Squirrel code paths doing language detection based on filenames #56378

@varungandhi-src

Description

@varungandhi-src

For example, see:

https://sourcegraph.com/github.com/sourcegraph/sourcegraph@64014d315541081a078bfd63473bd2fcca025005/-/blob/cmd/symbols/squirrel/languages.go?L34:5-34:14
https://sourcegraph.com/github.com/sourcegraph/sourcegraph@64014d3/-/blob/cmd/symbols/squirrel/language-file-extensions.json

This is fundamentally flawed because language detection cannot be done based on filenames in the general case, it requires examining the file's contents.

Since the Squirrel code paths are in Go, it might make sense to tackle this after or together with https://github.com/sourcegraph/sourcegraph/issues/56379

Metadata

Metadata

Assignees

No one assigned

    Labels

    graph/squirrelteam/graphGraph Team (previously Code Intel/Language Tools/Language Platform)tech-debtTechnical Debt

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions