This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Allow consumers to override useInputValidation state, use in AddUserEmailForm #16065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## cloud-emails-redesign-15409 #16065 +/- ##
===============================================================
- Coverage 52.40% 52.39% -0.01%
===============================================================
Files 1636 1636
Lines 81664 81673 +9
Branches 7141 7144 +3
===============================================================
- Hits 42795 42793 -2
- Misses 35048 35058 +10
- Partials 3821 3822 +1
|
felixfbecker
approved these changes
Nov 23, 2020
| value: overrideOptions?.value ?? '', | ||
| }) | ||
|
|
||
| if (overrideOptions?.value) { |
There was a problem hiding this comment.
Does this prevent overriding { value: '', validate: true }?
There was a problem hiding this comment.
Good catch, this should be overrideOptions?.validate, it doesn't matter what the value is
| } | ||
|
|
||
| eventLogger.log('NewUserEmailAddressAdded') | ||
| overrideEmailState() |
There was a problem hiding this comment.
nit: I think requiring { value: '' } to be passed would be a bit more readable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@felixfbecker I think that while
useInputValidation's return value is starting to get ugly, most consumers don't need to override state. Should we prioritize giving consumers control, or is this change sufficient for our use cases?