This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add product feedback page #17945
Merged
Add product feedback page #17945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #17945 +/- ##
==========================================
- Coverage 51.03% 51.01% -0.02%
==========================================
Files 1739 1737 -2
Lines 86848 86987 +139
Branches 7916 7750 -166
==========================================
+ Hits 44323 44378 +55
- Misses 38641 38728 +87
+ Partials 3884 3881 -3
|
|
Notifying subscribers in CODENOTIFY files for diff 32dda4a...f3cc0b0.
|
felixfbecker
approved these changes
Feb 5, 2021
quinnkeast
approved these changes
Feb 8, 2021
| authenticatedUser: Pick<AuthenticatedUser, 'email'> | ||
| } | ||
|
|
||
| const signUpForm = new URL('https://share.hsforms.com/1tkScUc65Tm-Yu98zUZcLGw1n7ku') |
There was a problem hiding this comment.
Just noticed this: This feels a bit weird because this URL is mutated on every render but shared between all instances of a component. This could cause issues when rendering it multiple times, e.g. in tests
There was a problem hiding this comment.
This shouldn't cause issues as set will just override any previous values but I agree this is a bit weird, PR to fix: https://github.com/sourcegraph/sourcegraph/pull/18171
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR:
jest-dommatchers for use withtesting-libraryand update tests to use these where suitable. These are more declarative and also provide additional tests. For example,toBeVisiblechecks the existence of the element but also ensure that it is not hidden from the user in someway (e.g.display: none). I have created an eslint plugin PR to our shared config to encourage the use of these withtesting-library: feat: add plugin-jest-dom eslint-config#188.Screenshots
Progress
Closes https://github.com/sourcegraph/sourcegraph/issues/17646
Closes https://github.com/sourcegraph/sourcegraph/issues/17647