This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Factor out store and zipcache from searcher to store pkg #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvantonder
commented
Apr 23, 2019
| const ( | ||
| // maxFileSize is the limit on file size in bytes. Only files smaller | ||
| // than this are searched. | ||
| maxFileSize = 1 << 20 // 1MB; match https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/sourcegraph/zoekt%24+%22-file_limit%22 |
There was a problem hiding this comment.
Turns out this const was only used by store, so I moved it there.
rvantonder
changed the title
ijsnow
approved these changes
Apr 24, 2019
|
@ijsnow Ha! No, not this time :) |
Codecov Report
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components
storeandzipcachecan be reused by upcomingreplacerservice, so am factoring it out ofsearchertopkg/storeinstead of copying.pkg/zipcachebut there's a circular dependency (zipcache_testdepends onstore/tmpStoreand store uses and depends on zipcache in its type definition. Wasn't obvious how to break the dependency.Test plan: None, this just moves around existing code.