Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

taras-yemets
Copy link
Contributor

@taras-yemets taras-yemets commented Feb 8, 2023

  1. Places code folding gutters before the blame decorations gutter.
    Note: Blame decorations can't go before the code folding gutters because of the way the former is implemented (TL;DR: blame decorations are not in the gutter, but inside the line, see https://github.com/sourcegraph/sourcegraph/pull/44148#issue-1442079069).
  2. Sets minimum height for selected lines layer markers to match the increased line height when the blame decorations are visible.
  3. Removes focus styles from .cm-content (redundant blue line below the content reported in Slack).
  4. Removes selection layer overflow reported in Slack.

Though some of these changes seem unrelated I put them in a single PR because all of them originate from selected text and lines layers configuration.

Screen.Recording.2023-02-08.at.18.35.57.mov

Test plan

Tested manually (video attached).

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot bot added the cla-signed label Feb 8, 2023
@sg-e2e-regression-test-bob
Copy link

sg-e2e-regression-test-bob commented Feb 8, 2023

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.29 kb) 0.00% (+0.29 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits cf8f11b and 0b2dca3 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@taras-yemets taras-yemets marked this pull request as ready for review February 8, 2023 16:40
@taras-yemets taras-yemets requested a review from a team February 8, 2023 16:40
}

:global(.cm-editor:not(:focus-within) .focus-visible) {
:global(.cm-editor:not(:focus-within) :focus-visible) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is tricky indeed!

@taras-yemets taras-yemets merged commit 1157577 into main Feb 9, 2023
@taras-yemets taras-yemets deleted the taras-yemets/cm-blob-fix-gutters-conlict branch February 9, 2023 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants