This repository was archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
blob: fix gutters style conflicts #47463
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits cf8f11b and 0b2dca3 or learn more. Open explanation
|
3 tasks
taras-yemets
commented
Feb 8, 2023
} | ||
|
||
:global(.cm-editor:not(:focus-within) .focus-visible) { | ||
:global(.cm-editor:not(:focus-within) :focus-visible) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
valerybugakov
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is tricky indeed!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Blame decorations can't go before the code folding gutters because of the way the former is implemented (TL;DR: blame decorations are not in the gutter, but inside the line, see https://github.com/sourcegraph/sourcegraph/pull/44148#issue-1442079069).
.cm-content
(redundant blue line below the content reported in Slack).Though some of these changes seem unrelated I put them in a single PR because all of them originate from selected text and lines layers configuration.
Screen.Recording.2023-02-08.at.18.35.57.mov
Test plan
Tested manually (video attached).
App preview:
Check out the client app preview documentation to learn more.