This repository was archived by the owner on Sep 30, 2024. It is now read-only.
deploy: correct blobstore endpoint in sourcegraph/server image (fix 'main' CI) #54601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…main' CI) We still use `sourcegraph/server` to run our integration tests in our CI pipelines (yuck) and in my change #54466 I failed to realize that `IsSingleBinary()` and `IsDeployTypeSingleDockerContainer(Type())` report different things. This fixes the issue, and likely fixes `main` on our CI pipelines. Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
davejrt
approved these changes
Jul 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still use
sourcegraph/serverto run our integration tests in our CI pipelines (yuck) and in my change #54466 I failed to realize thatIsSingleBinary()andIsDeployTypeSingleDockerContainer(Type())report different things.This fixes the issue, and likely fixes
mainon our CI pipelines. If not, then both this change and the other should be reverted.Test plan
CI